Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Per ChunkArea PushConstants + VRAM Usage Reductions V2 #361

Merged
merged 9 commits into from
Jan 28, 2024

Conversation

thr3343
Copy link
Contributor

@thr3343 thr3343 commented Jan 12, 2024

(Originally from #358, but split some of its optimisations + features into 2 additional PRs to improve readibility: #360 + #359)

Similar to the prior PR: #345
But with major code cleanups + some additional enhancements and improvements

  • CPU cache-miss fixes
    • Prior PR had a major problem with high CPU cache misses, causing major chunk loading lag and regressions
    • This has been fixed so chunk loads perform roughly the same as upstream
  • Low VRAM mode
    • Splits the vertex Areabuffer into separate per Rendertype vertexbuffers
    • Allows for more granular + precise resizing, which can reduce VRAM by roughly 20% or more
    • This can effect performance on some hardware, so its disabled by default

@xCollateral xCollateral merged commit 9e3f7b1 into xCollateral:1.20.x Jan 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants