-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chunk Rendering Optimisations + VRAM Usage Reductions #328
Closed
thr3343
wants to merge
12
commits into
xCollateral:1.20.x
from
thr3343:ExpChunkRefactors+Optimisations
Closed
Chunk Rendering Optimisations + VRAM Usage Reductions #328
thr3343
wants to merge
12
commits into
xCollateral:1.20.x
from
thr3343:ExpChunkRefactors+Optimisations
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix Incorrect RenderType Skip DrawCommand if empty
thr3343
force-pushed
the
ExpChunkRefactors+Optimisations
branch
from
November 20, 2023 12:55
62c2e6a
to
b321d56
Compare
(Hopefully won't cause performance regressions due to the Int to Float Casts + Mixed Integer + Float Workloads)
thr3343
force-pushed
the
ExpChunkRefactors+Optimisations
branch
from
November 20, 2023 12:55
b321d56
to
dcff864
Compare
thr3343
force-pushed
the
ExpChunkRefactors+Optimisations
branch
2 times, most recently
from
November 21, 2023 15:24
333a145
to
a86a65a
Compare
thr3343
changed the title
Chunk Rendering Optimisations + Refactors
Chunk Rendering Optimisations + VRAM Usage Reductions
Nov 21, 2023
thr3343
force-pushed
the
ExpChunkRefactors+Optimisations
branch
2 times, most recently
from
November 21, 2023 17:02
e6be2a7
to
d5349e2
Compare
…TerrainRenderType
thr3343
force-pushed
the
ExpChunkRefactors+Optimisations
branch
from
November 21, 2023 17:28
d5349e2
to
a7c95e0
Compare
(i.e. Typically those using custom world height mods/datapacks that permit for world heights > 320)
thr3343
force-pushed
the
ExpChunkRefactors+Optimisations
branch
from
November 21, 2023 22:29
9ac99ed
to
39e608b
Compare
thr3343
force-pushed
the
ExpChunkRefactors+Optimisations
branch
from
November 25, 2023 18:08
a6222c1
to
92bb190
Compare
thr3343
force-pushed
the
ExpChunkRefactors+Optimisations
branch
from
November 25, 2023 18:11
92bb190
to
5d544c9
Compare
Think i'll do a way better + cleaned up version of this PR rebased on 0.3.6 code, so will close this atm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was originally a part of an older version of the Wayland PR,
But was later spun off into a separate PR with additional improvements and cleanups
This heavily leverages and exploits TerrainRenderTypes to enable certain optimisations,
This will replace much of the prior usages of RenderTypes, so hopefully this won't cause too many issues
Quick/Brief Summary (Badly formatted sorry)