Fix Segfault on Wayland when closing the client

(i.e. Wayland is fussy about the order, and Window handle must be destroyed after the Swapchain and vkInstance, and not before)

Rebase

This reverts commit 7eb7a5f.

Refactor Chunk rendering + Improve Draw Direct Performance

Make PushConstants per ChunkArea instead of per RenderSection;  Reduces PushConstant CPU usage by over 100x in DrawCall heavy scenarios

Use compile time length for ChunkArea SectionQueues to improve JIT Optimisations

Merge Direct/Indirect Shaders:
Use same shader for both Direct and Draw Indirect + remove Indirect Pipeline

Skip 0 index (i.e. empty draw calls) checks + reduce DescriptorSet binding Frequency

Faster Gaussian Sky Blending

[GPU Optimisation]: Separate VertexBuffers per RenderType

Use Queue Enum + Split CommandPools based on Queue/Operation Type

Dedicated Transfer Queue specific fixes

Enable VK12 VMA Features

Bizarrely Improves Performance by at least 15/20% according to initial testing

Optimise Chunk Shader

(May either have no performance improvement and/or have possible Shader/Visual artefacts)

Early-Z Optimisations + Reduce AreaBuffer Fragmentation + Final Cleanup

(Quick Summary)

* Align Sizes to power of 2
* Reduce Pipeline Binding Frequency
* Refactor ChunkTask to use RenderType enums to reduce CPU +
* improve JIT optimisations
* Try to use Early-Z on Translucent RenderType

Fix Segfault on Wayland when closing the client

(i.e. Wayland is fussy about the order, and Window handle must be destroyed after the Swapchain and vkInstance, and not before)

Revert "Rebase"

This reverts commit f0382e3.

src/main/java/net/vulkanmod/mixin/render/MinecraftMixin.java

@@ -140,7 +140,11 @@ public void close(CallbackInfo ci) {
         Vulkan.waitIdle();
 
     }
-    @Inject(method = "close", at = @At(value = "RETURN"))
+    /**
+     * @author
+     * @reason On Wayland the window (apparently) can only be safely destroyed after both SwapChain and VkInstance are Destroyed, and not before (Hence injecting at HEAD and not RETURN)
+     */
+    @Inject(method = "close", at = @At(value = "HEAD"))
     public void close2(CallbackInfo ci) {
 
         Vulkan.cleanUp();

src/main/java/net/vulkanmod/vulkan/Renderer.java

@@ -426,6 +426,7 @@ public void cleanUpResources() {
 
         TerrainShaderManager.destroyPipelines();
         VTextureSelector.getWhiteTexture().free();
+        VTextureSelector.freeAll();
     }
 
     private void destroySyncObjects() {

src/main/java/net/vulkanmod/vulkan/Vulkan.java

@@ -9,6 +9,7 @@
 import net.vulkanmod.vulkan.queue.Queue;
 import net.vulkanmod.vulkan.queue.TransferQueue;
 import net.vulkanmod.vulkan.shader.Pipeline;
+import net.vulkanmod.vulkan.texture.VTextureSelector;
 import net.vulkanmod.vulkan.texture.VulkanImage;
 import net.vulkanmod.vulkan.util.VUtil;
 import org.lwjgl.PointerBuffer;
@@ -194,11 +195,13 @@ public static void cleanUp() {
         vkDestroyFence(Device.device, immediateFence, null);
 
         Pipeline.destroyPipelineCache();
+//        WorldRenderer.getInstance().cleanUp();
+        Renderer.getInstance().cleanUpResources();
+        swapChain.getRenderPass().cleanUp();
         swapChain.cleanUp();
 
-        Renderer.getInstance().cleanUpResources();
         freeStagingBuffers();
-
+//        VTextureSelector.freeAll();
         try {
             MemoryManager.getInstance().freeAllBuffers();
         } catch (Exception e) {

src/main/java/net/vulkanmod/vulkan/framebuffer/RenderPass.java

@@ -227,7 +227,6 @@ public long getId() {
     public static class AttachmentInfo {
         final Type type;
         final int format;
-        VulkanImage attachment;
         int initialLayout;
         int loadOp;
         int storeOp;

src/main/java/net/vulkanmod/vulkan/texture/VTextureSelector.java

@@ -86,4 +86,10 @@ public static VulkanImage getOverlayTexture() {
     public static VulkanImage getBoundTexture() { return boundTexture; }
 
     public static VulkanImage getWhiteTexture() { return whiteTexture; }
+
+    public static void freeAll()
+    {
+        framebufferTexture.doFree();
+        framebufferTexture2.doFree();
+    }
 }