Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if signature validation with certificate alias is enabled for disabling request signature validation checkbox #7297

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

shanggeeth
Copy link
Contributor

Purpose

  • When signature validation with certificate alias is enabled, we need to allow enabling the request signature validation even when a certificate is not uploaded specific to the application.

Related Issue

@wso2-jenkins-bot
Copy link
Contributor

🦋 Changeset detected

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.04%. Comparing base (5643d2d) to head (647e28c).
Report is 146 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7297   +/-   ##
=======================================
  Coverage   36.04%   36.04%           
=======================================
  Files          42       42           
  Lines         899      899           
  Branches      218      222    +4     
=======================================
  Hits          324      324           
- Misses        529      555   +26     
+ Partials       46       20   -26     
Flag Coverage Δ
@wso2is/core 36.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

@shanggeeth shanggeeth merged commit 5fd6851 into wso2:master Jan 16, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants