Validate and Sanitize backToUrl in self-registration-username-request.jsp #7250
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request includes changes to the
self-registration-username-request.jsp
file in theidentity-apps-core/apps/recovery-portal/src/main/webapp
directory. The changes primarily focus on improving security and error handling for callback URLs.Improvements to security and error handling:
backToUrl
parameter is now validated usingUtils.validateCallbackURL
and is checked against a configured callback regex.error.jsp
with a corresponding error message.href
attribute for the "Sign in" button has been updated to escape HTML characters in thebackToUrl
parameter usingStringEscapeUtils.escapeHtml4
.Checklist
Security checks