Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable role creation and deletion capability in sub organization level #7240

Merged

Conversation

ShanChathusanda93
Copy link
Contributor

@ShanChathusanda93 ShanChathusanda93 commented Jan 2, 2025

Purpose

  • $subject
  • Enabled the role creation button for the sub organization level in Console application.
  • Improve the role creation wizard's notes.
  • Enable the role deletion based on the role property which defines that the role is not a shared role.
  • Add a label to mention that the role is a shared roles in sub organization level.

Related Issues

Related PRs

Checklist

  • e2e cypress tests locally verified. (for internal contributers)
  • Manual test round performed and verified.
  • UX/UI review done on the final implementation.
  • Documentation provided. (Add links if there are any)
  • Relevant backend changes deployed and verified
  • Unit tests provided. (Add links if there are any)
  • Integration tests provided. (Add links if there are any)

Security checks

@ShanChathusanda93 ShanChathusanda93 force-pushed the sub-org-roles-impr-branch branch from 2807909 to d0ea674 Compare January 2, 2025 10:37
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.04%. Comparing base (bbb1d92) to head (c01fab3).
Report is 318 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7240      +/-   ##
==========================================
+ Coverage   32.32%   36.04%   +3.71%     
==========================================
  Files          42       42              
  Lines         897      899       +2     
  Branches      221      222       +1     
==========================================
+ Hits          290      324      +34     
+ Misses        607      529      -78     
- Partials        0       46      +46     
Flag Coverage Δ
@wso2is/core 36.04% <ø> (+3.71%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 16 files with indirect coverage changes

@ShanChathusanda93
Copy link
Contributor Author

There is an ESLint build failure with the following error.

/home/runner/work/identity-apps/identity-apps/features/admin.roles.v2/components/role-list.tsx
Error:   26:10  error  'hasRequiredScopes' import from '@wso2is/core/helpers' is restricted. Please use "import { useRequiredScopes } from '@wso2is/access-control'" instead. Refer documentation: https://github.com/wso2/identity-apps/blob/master/docs/write-code/PERFORMANCE.md#use-userequiredscopes-hook-instead-of-hasrequiredscopes-function  no-restricted-imports

The initial change that is introducing in this PR does not contains any change to the scope handling level. @brionmario is there any possibility to skip this change in this PR?

pavinduLakshan
pavinduLakshan previously approved these changes Jan 3, 2025
brionmario
brionmario previously approved these changes Jan 3, 2025
@brionmario
Copy link
Member

There is an ESLint build failure with the following error.

/home/runner/work/identity-apps/identity-apps/features/admin.roles.v2/components/role-list.tsx
Error:   26:10  error  'hasRequiredScopes' import from '@wso2is/core/helpers' is restricted. Please use "import { useRequiredScopes } from '@wso2is/access-control'" instead. Refer documentation: https://github.com/wso2/identity-apps/blob/master/docs/write-code/PERFORMANCE.md#use-userequiredscopes-hook-instead-of-hasrequiredscopes-function  no-restricted-imports

The initial change that is introducing in this PR does not contains any change to the scope handling level. @brionmario is there any possibility to skip this change in this PR?

+1
Lets skip for this PR

@ShanChathusanda93 ShanChathusanda93 force-pushed the sub-org-roles-impr-branch branch 3 times, most recently from ff99f63 to cd73542 Compare January 3, 2025 11:36
pavinduLakshan
pavinduLakshan previously approved these changes Jan 3, 2025
Copy link
Contributor

@DonOmalVindula DonOmalVindula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's address the ESLint warnings as well

features/admin.roles.v2/components/role-list.tsx Outdated Show resolved Hide resolved
@ShanChathusanda93 ShanChathusanda93 force-pushed the sub-org-roles-impr-branch branch 2 times, most recently from 03223a5 to 4dd1597 Compare January 8, 2025 11:50
@ShanChathusanda93 ShanChathusanda93 force-pushed the sub-org-roles-impr-branch branch from 4dd1597 to c01fab3 Compare January 8, 2025 13:58
@wso2-jenkins-bot
Copy link
Contributor

🦋 Changeset detected

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants