Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move common i18n extensions in console app to i18n module #7235

Merged
merged 4 commits into from
Jan 9, 2025

Conversation

pavinduLakshan
Copy link
Contributor

Purpose

$subject

Related Issues

  • N/A

Related PRs

  • N/A

Checklist

  • e2e cypress tests locally verified. (for internal contributers)
  • Manual test round performed and verified.
  • UX/UI review done on the final implementation.
  • Documentation provided. (Add links if there are any)
  • Relevant backend changes deployed and verified
  • Unit tests provided. (Add links if there are any)
  • Integration tests provided. (Add links if there are any)

Security checks

@pavinduLakshan pavinduLakshan changed the title Move common i18n extensions in console app to i18n module Move common i18n extensions in console app to i18n module Dec 22, 2024
@pavinduLakshan pavinduLakshan marked this pull request as draft December 22, 2024 05:38
@pavinduLakshan pavinduLakshan marked this pull request as ready for review December 22, 2024 08:03
Copy link

codecov bot commented Dec 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.04%. Comparing base (287bc55) to head (c62ac96).
Report is 129 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7235   +/-   ##
=======================================
  Coverage   36.04%   36.04%           
=======================================
  Files          42       42           
  Lines         899      899           
  Branches      222      218    -4     
=======================================
  Hits          324      324           
+ Misses        575      529   -46     
- Partials        0       46   +46     
Flag Coverage Δ
@wso2is/core 36.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 15 files with indirect coverage changes

@pavinduLakshan pavinduLakshan force-pushed the move_common_extensions branch from 2a97363 to c62ac96 Compare January 9, 2025 10:16
@wso2-jenkins-bot
Copy link
Contributor

🦋 Changeset detected

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

@pavinduLakshan pavinduLakshan merged commit 6ffd99f into wso2:master Jan 9, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants