-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve UI to incorporate authentication flow with the external authentication service #7207
Draft
Shenali-SJ
wants to merge
13
commits into
wso2:master
Choose a base branch
from
Shenali-SJ:custom-authentication
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,444
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7207 +/- ##
==========================================
+ Coverage 32.02% 36.04% +4.01%
==========================================
Files 41 42 +1
Lines 893 899 +6
Branches 204 222 +18
==========================================
+ Hits 286 324 +38
+ Misses 607 555 -52
- Partials 0 20 +20
Flags with carried forward coverage won't be shown. Click here to find out more. |
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. |
Shenali-SJ
force-pushed
the
custom-authentication
branch
from
January 16, 2025 06:38
0086afa
to
9a1c599
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR onboard the UI related components associated with custom authentication feature.
Currently custom authentication creation is supported through
Create a New Connection
page.There are three custom authentication types which will be represented as three cards.
Implemented design
Create a New Connection
Page)We have also introduced new icons with this feature.
Sub Tasks
As of now, we have completed UI components related to the create wizard and the following sub tasks are still in progress.
Authentication Type
step in the wizard.Related Issues
Related PRs
Design Discussions
Checklist
Security checks