Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve UI to incorporate authentication flow with the external authentication service #7207

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

Shenali-SJ
Copy link
Contributor

@Shenali-SJ Shenali-SJ commented Dec 12, 2024

Purpose

This PR onboard the UI related components associated with custom authentication feature.

Currently custom authentication creation is supported through Create a New Connection page.
There are three custom authentication types which will be represented as three cards.

  • External (Federated) Custom Authentication
  • Internal User Authentication
  • 2FA Authentication

Implemented design

  • Custom Authentication group card (In Create a New Connection Page)
image
  • Create Wizard - Step 01
image
  • Create Wizard - Step 02
image
  • Create Wizard - Step 03
image

We have also introduced new icons with this feature.

Sub Tasks

As of now, we have completed UI components related to the create wizard and the following sub tasks are still in progress.

  • Integrate APIs with the create wizard
  • Move the UI texts to i18n
  • Introduce a new icon for Authentication Type step in the wizard.

Related Issues

Related PRs

Design Discussions

Checklist

  • e2e cypress tests locally verified. (for internal contributers)
  • Manual test round performed and verified.
  • UX/UI review done on the final implementation.
  • Documentation provided. (Add links if there are any)
  • Relevant backend changes deployed and verified
  • Unit tests provided. (Add links if there are any)
  • Integration tests provided. (Add links if there are any)

Security checks

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.04%. Comparing base (aeeeed4) to head (0086afa).
Report is 631 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7207      +/-   ##
==========================================
+ Coverage   32.02%   36.04%   +4.01%     
==========================================
  Files          41       42       +1     
  Lines         893      899       +6     
  Branches      204      222      +18     
==========================================
+ Hits          286      324      +38     
+ Misses        607      555      -52     
- Partials        0       20      +20     
Flag Coverage Δ
@wso2is/core 36.04% <ø> (+4.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 10 files with indirect coverage changes

@wso2-jenkins-bot
Copy link
Contributor

⚠️ No Changeset found

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go.

If these changes should result in a version bump, you need to add a changeset.

Refer Release Documentation to learn how to add a changeset.

@Shenali-SJ Shenali-SJ force-pushed the custom-authentication branch from 0086afa to 9a1c599 Compare January 16, 2025 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants