Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify few data-componentids in Actions UI #6811

Merged
merged 2 commits into from
Aug 25, 2024
Merged

Modify few data-componentids in Actions UI #6811

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07f8029
Fix data-componentids in actions component
ashanthamara Aug 25, 2024
fa4abc1
Added changeset
ashanthamara Aug 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/rotten-deers-cough.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@wso2is/admin.actions.v1": patch
---

Fix data-componentids in actions component
6 changes: 4 additions & 2 deletions features/admin.actions.v1/components/action-config-form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,7 +368,9 @@ const ActionConfigForm: FunctionComponent<ActionConfigFormInterface> = ({
return (
<Alert severity="info">
<AlertTitle
className="alert-title">
className="alert-title"
data-componentid={ `${ _componentId }-authentication-info-box-title` }
>
<Trans
i18nKey={
authenticationType === AuthenticationType.NONE ?
Expand Down Expand Up @@ -688,7 +690,7 @@ const ActionConfigForm: FunctionComponent<ActionConfigFormInterface> = ({
} }
ariaLabel="endpointUri"
required={ true }
data-componentid={ `${ _componentId }-action-name` }
data-componentid={ `${ _componentId }-action-endpointUri` }
name="endpointUri"
type="text"
label={ t("actions:fields.endpoint.label") }
Expand Down
2 changes: 1 addition & 1 deletion features/admin.actions.v1/pages/action-configuration-page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,7 +365,7 @@ const ActionConfigurationPage: FunctionComponent<ActionConfigurationPageInterfac
sectionHeader={ t("actions:dangerZoneGroup.header") }
>
<DangerZone
data-componentid={ `${ _componentId }-delete-action-of-type-${ actionTypeApiPath}` }
data-componentid={ `${ _componentId }-danger-zone` }
actionTitle={
t("actions:dangerZoneGroup.revertConfig.actionTitle")
}
Expand Down
10 changes: 8 additions & 2 deletions features/admin.actions.v1/pages/actions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,10 @@ export const ActionTypesListingPage: FunctionComponent<ActionTypesListingPageInt

if (count > 0) {
return (
<div className="status-tag">
<div
className="status-tag"
data-componentid={ `${ _componentId }-${ actionType }-configured-status-tag` }
>
<CircleCheckFilledIcon className="icon-configured"/>
<Typography className="text-configured" variant="h6">
{ t("actions:status.configured") }
Expand All @@ -218,7 +221,10 @@ export const ActionTypesListingPage: FunctionComponent<ActionTypesListingPageInt
);
} else {
return (
<div className="status-tag">
<div
className="status-tag"
data-componentid={ `${ _componentId }-${ actionType }-not-configured-status-tag` }
>
<Typography className="text-not-configured" variant="h6">
{ t("actions:status.notConfigured") }
</Typography>
Expand Down
Loading