Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add TransferFees conformance note #4212

Merged
merged 3 commits into from
Jan 10, 2025

Conversation

joelsmith-2019
Copy link
Collaborator

@joelsmith-2019 joelsmith-2019 commented Jan 8, 2025

Adds a note to the whitepaper in reference to issue #4211.

@joelsmith-2019 joelsmith-2019 self-assigned this Jan 8, 2025
@joelsmith-2019 joelsmith-2019 force-pushed the joel/whitepaper-payload-note branch from 9e35a9f to 5d9aa3c Compare January 8, 2025 16:19
djb15
djb15 previously approved these changes Jan 8, 2025
nik-suri
nik-suri previously approved these changes Jan 8, 2025
@joelsmith-2019 joelsmith-2019 marked this pull request as ready for review January 8, 2025 18:34
Copy link
Contributor

@evan-gray evan-gray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to confirm each of the implementations to ensure there are no other deviations that should be noted.

whitepapers/0004_message_publishing.md Outdated Show resolved Hide resolved
@joelsmith-2019 joelsmith-2019 dismissed stale reviews from nik-suri and djb15 via aacb21a January 9, 2025 19:36
@joelsmith-2019
Copy link
Collaborator Author

Would be good to confirm each of the implementations to ensure there are no other deviations that should be noted.

Outside of the Solana implementation you pointed out directly in the issue, I was only able to find this auto generated go binding for evm connectors for ethabi.
https://github.com/wormhole-foundation/wormhole/blob/main/node/pkg/watchers/evm/connectors/ethabi/abi.go#L55-L61

@joelsmith-2019 joelsmith-2019 merged commit 83224c5 into main Jan 10, 2025
28 checks passed
@joelsmith-2019 joelsmith-2019 deleted the joel/whitepaper-payload-note branch January 10, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants