Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NatSpec Documentation to Ethereum Contracts #3489

Conversation

fahimahmedx
Copy link

This adds NatSpec documentation to some (but many) of the solidity files used for Wormhole's Ethereum contracts. Issue #3477

@barnjamin
Copy link
Contributor

Hey @fahimahmedx, thanks for taking the time to work on this!

As they are right now, the doc strings seem pretty generic and are missing the context that they should provide to the dev.

e.g.
image

This doc string doesn't add much to a dev's understanding. Could you provide additional context to the docstrings?

for the above example, you'd want to mention that this chain id is the Wormhole Chain Id, potentially to a link with more information

@fahimahmedx
Copy link
Author

Will update, thank you!

@SEJeff
Copy link
Collaborator

SEJeff commented Dec 12, 2023

@fahimahmedx have you had a chance to update this? I'm going through old PRs and trying to get them closed or merged.

@evan-gray
Copy link
Contributor

Closing as @barnjamin ’s comment regarding lack of meaningful context in these comments has not been resolved.

@evan-gray evan-gray closed this Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants