Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Wormhole SDK Page #9

Merged
merged 76 commits into from
Aug 22, 2024
Merged

Add Wormhole SDK Page #9

merged 76 commits into from
Aug 22, 2024

Conversation

themacexpert
Copy link
Collaborator

@themacexpert themacexpert commented Aug 2, 2024

Description

Migrates Wormhole SDK page according to docs standards

Checklist

  • Required - I have added a label to this PR 🏷️
  • Required - I have run my changes through Grammarly
  • If pages have been moved, I have created redirects in the wormhole-mkdocs repo

@themacexpert themacexpert requested a review from eshaben August 2, 2024 22:03
@themacexpert themacexpert added the A0 - New Content Pull request contains new content pages label Aug 3, 2024
@eshaben eshaben requested a review from dawnkelly09 August 6, 2024 15:57
Copy link
Collaborator

@dawnkelly09 dawnkelly09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to catch all the instances of specific changes requested but, please make sure you are applying them (when applicable) across the entire document. Please pay special attention to comments around code snippets. Thank you!

build/build-multichain-applications/wormhole-sdk.md Outdated Show resolved Hide resolved
build/build-multichain-applications/wormhole-sdk.md Outdated Show resolved Hide resolved
build/build-multichain-applications/wormhole-sdk.md Outdated Show resolved Hide resolved
build/build-multichain-applications/wormhole-sdk.md Outdated Show resolved Hide resolved
build/build-multichain-applications/wormhole-sdk.md Outdated Show resolved Hide resolved
build/build-multichain-applications/wormhole-sdk.md Outdated Show resolved Hide resolved
build/build-multichain-applications/wormhole-sdk.md Outdated Show resolved Hide resolved
build/build-multichain-applications/wormhole-sdk.md Outdated Show resolved Hide resolved
build/build-multichain-applications/wormhole-sdk.md Outdated Show resolved Hide resolved
build/build-multichain-applications/wormhole-sdk.md Outdated Show resolved Hide resolved
themacexpert and others added 12 commits August 6, 2024 11:17
Co-authored-by: Dawn Kelly <83190195+dawnkelly09@users.noreply.github.com>
Co-authored-by: Dawn Kelly <83190195+dawnkelly09@users.noreply.github.com>
Co-authored-by: Dawn Kelly <83190195+dawnkelly09@users.noreply.github.com>
Co-authored-by: Dawn Kelly <83190195+dawnkelly09@users.noreply.github.com>
Co-authored-by: Dawn Kelly <83190195+dawnkelly09@users.noreply.github.com>
Co-authored-by: Dawn Kelly <83190195+dawnkelly09@users.noreply.github.com>
Co-authored-by: Dawn Kelly <83190195+dawnkelly09@users.noreply.github.com>
Co-authored-by: Dawn Kelly <83190195+dawnkelly09@users.noreply.github.com>
'
Copy link
Collaborator

@dawnkelly09 dawnkelly09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Evolving nicely. :-)

build/build-multichain-applications/wormhole-sdk.md Outdated Show resolved Hide resolved
build/build-multichain-applications/wormhole-sdk.md Outdated Show resolved Hide resolved
build/build-multichain-applications/wormhole-sdk.md Outdated Show resolved Hide resolved
build/build-multichain-applications/wormhole-sdk.md Outdated Show resolved Hide resolved
build/build-multichain-applications/wormhole-sdk.md Outdated Show resolved Hide resolved
build/build-multichain-applications/wormhole-sdk.md Outdated Show resolved Hide resolved
build/build-multichain-applications/wormhole-sdk.md Outdated Show resolved Hide resolved
themacexpert and others added 6 commits August 8, 2024 16:06
Co-authored-by: Dawn Kelly <83190195+dawnkelly09@users.noreply.github.com>
Co-authored-by: Dawn Kelly <83190195+dawnkelly09@users.noreply.github.com>
Co-authored-by: Dawn Kelly <83190195+dawnkelly09@users.noreply.github.com>
Co-authored-by: Dawn Kelly <83190195+dawnkelly09@users.noreply.github.com>
Copy link
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was trying to review quickly, but it looked like there were a lot of snippets that could still be cleaned up and we could use one snippet and use snippet lines to point out a specific section of code. Please check through all the snippets to see if this is the case! Thank you!!

.snippets/code/build/build-apps/wormhole-sdk/addresses.ts Outdated Show resolved Hide resolved
.snippets/code/build/build-apps/wormhole-sdk/cctp.ts Outdated Show resolved Hide resolved
.snippets/code/build/build-apps/wormhole-sdk/cctp.ts Outdated Show resolved Hide resolved
.snippets/code/build/build-apps/wormhole-sdk/cctp.ts Outdated Show resolved Hide resolved
.snippets/code/build/build-apps/wormhole-sdk/cctp.ts Outdated Show resolved Hide resolved
build/build-apps/wormhole-sdk.md Outdated Show resolved Hide resolved
build/build-apps/wormhole-sdk.md Outdated Show resolved Hide resolved
build/build-apps/wormhole-sdk.md Outdated Show resolved Hide resolved
build/build-apps/wormhole-sdk.md Outdated Show resolved Hide resolved
build/build-apps/wormhole-sdk.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Snippets look good! I think there might be one that can be deleted - core-bridge.ts, seems like example-core-bridge.ts is used instead. But please double check

Just saw a couple minor things, but after this it'll be good to merge! 🚀

build/build-apps/wormhole-sdk.md Outdated Show resolved Hide resolved
build/build-apps/wormhole-sdk.md Outdated Show resolved Hide resolved
build/build-apps/wormhole-sdk.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@dawnkelly09 dawnkelly09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the couple of pending changes Erin tagged and then this LGTM. Nice work, Kevin. This really turned out nicely.

themacexpert and others added 4 commits August 19, 2024 16:05
Co-authored-by: Erin Shaben <eshaben@icloud.com>
Co-authored-by: Erin Shaben <eshaben@icloud.com>
Co-authored-by: Erin Shaben <eshaben@icloud.com>
@themacexpert themacexpert requested a review from eshaben August 19, 2024 23:14
Copy link
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!! LGTM! ✨

@eshaben eshaben merged commit 518f963 into main Aug 22, 2024
1 check passed
@eshaben eshaben deleted the themacexpert/buildMulti branch August 22, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A0 - New Content Pull request contains new content pages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants