Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update start building section and chain configs #167

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

eshaben
Copy link
Collaborator

@eshaben eshaben commented Dec 10, 2024

Description

This PR includes the following changes:

  • It removes get started with X pages. These pages had a lot of duplicate content that you can find in the reference section
  • It updates the supported networks pages and separates the networks by environment and switches to a table format to make it easier to scan. The icons were nice, but I feel like it's more concise this way. If you have alternative suggestions or ideas, let me know 🙂
  • It switches the testnet faucets page to split the testnets up by environment and show the faucet data in tables
  • It also updates the reference section pages to include the latest chain data. Removing any rows without data so these tables can be a bit cleaner

Checklist

@eshaben eshaben added the A1 - Maintenance Major Pull request contains major updates to an existing page (i.e., adding a new section, reorgs, etc.) label Dec 10, 2024
Copy link
Collaborator

@martin0995 martin0995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I left one small comment on this PR related to the Supported Networks and Testnet Faucets links.

@eshaben eshaben changed the title Update start building section Update start building section and chain configs Dec 10, 2024
Copy link
Collaborator

@ilariae ilariae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@eshaben eshaben merged commit d0c01c0 into main Dec 10, 2024
1 check passed
@eshaben eshaben deleted the eshaben/supported-envs branch December 10, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A1 - Maintenance Major Pull request contains major updates to an existing page (i.e., adding a new section, reorgs, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants