-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hum: batch process obs #371
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bingyuyap <bingyu.yap.21@gmail.com>
hum: fix tests hum: add tests for flushing hum: clean up hum: final clean up Signed-off-by: bingyuyap <bingyu.yap.21@gmail.com>
bingyuyap
force-pushed
the
bing/hum-batch-process
branch
from
September 4, 2024 04:13
c6ac8c1
to
28f6551
Compare
bruce-riley
reviewed
Sep 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not quite done yet, but here's what I've got so far.
bruce-riley
approved these changes
Sep 4, 2024
Signed-off-by: bingyuyap <bingyu.yap.21@gmail.com>
bingyuyap
force-pushed
the
bing/hum-batch-process
branch
from
September 4, 2024 17:22
2348a4f
to
34511fa
Compare
bingyuyap
force-pushed
the
bing/hum-negative-obs-count
branch
from
September 4, 2024 17:28
d522ad1
to
58a2a33
Compare
bruce-riley
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR batches observation for processing to reduce DB calls to bigtable, which is the main bottle neck of the performance for processing. This causes the buffer to max out utilisation and drop observations before we can even process them.
High level:
batchLimit
(for now its 100) or every 5 seconds, process the batchHigh level of batch processing:
Currently on logs, without batching, a buffer size of 20,000 is at 99-100%. Which causes buffer to drop observations. With this change, the utilisation of the buffer is at 0-2% with a size of 1024.