Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add testnet monitor with fly, watcher, dashboard #167

Merged
merged 2 commits into from
Jan 9, 2024
Merged

Add testnet monitor with fly, watcher, dashboard #167

merged 2 commits into from
Jan 9, 2024

Conversation

panoel
Copy link
Contributor

@panoel panoel commented Dec 19, 2023

No description provided.

@panoel panoel force-pushed the add_monitor_to_testnet_dashboard branch from 4fb15c5 to 3652029 Compare December 20, 2023 16:25
@panoel panoel force-pushed the add_monitor_to_testnet_dashboard branch from 2451b24 to 769fc49 Compare January 3, 2024 20:08
@panoel panoel requested a review from bingyuyap January 3, 2024 20:09
@panoel panoel force-pushed the add_monitor_to_testnet_dashboard branch from 70d1408 to 38d65e6 Compare January 4, 2024 15:36
@panoel panoel marked this pull request as ready for review January 4, 2024 16:23
bingyuyap
bingyuyap approved these changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@bingyuyap bingyuyap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@panoel panoel force-pushed the add_monitor_to_testnet_dashboard branch from ed0a1a1 to 246a7fd Compare January 9, 2024 14:40
@panoel panoel changed the title dashboard/components: add testnet with cloudfunction Add testnet monitor with fly, watcher, dashboard Jan 9, 2024
@panoel panoel force-pushed the add_monitor_to_testnet_dashboard branch 2 times, most recently from 0a2f3c8 to 846df9d Compare January 9, 2024 17:33
@evan-gray evan-gray force-pushed the add_monitor_to_testnet_dashboard branch from 846df9d to 1493088 Compare January 9, 2024 19:09
evan-gray
evan-gray previously approved these changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@evan-gray evan-gray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like a reasonable refactor, just one small nit.

watcher/src/watchers/MoonbeamWatcher.ts Outdated Show resolved Hide resolved
@panoel panoel force-pushed the add_monitor_to_testnet_dashboard branch from 4a59be3 to 7bdfc85 Compare January 9, 2024 20:08
@panoel panoel requested a review from evan-gray January 9, 2024 20:10
@panoel panoel merged commit 2571991 into main Jan 9, 2024
3 checks passed
@panoel panoel deleted the add_monitor_to_testnet_dashboard branch January 9, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bingyuyap bingyuyap bingyuyap approved these changes

@evan-gray evan-gray evan-gray approved these changes

@barnjamin barnjamin Awaiting requested review from barnjamin

@kev1n-peters kev1n-peters Awaiting requested review from kev1n-peters

@bruce-riley bruce-riley Awaiting requested review from bruce-riley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@panoel @evan-gray @bingyuyap