fly: put tunables into .env file #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panoel
force-pushed
the
fly_should_use_env_file
branch
from
fec079b to
6060855
Compare
bruce-riley
reviewed
Dec 13, 2023
panoel
force-pushed
the
fly_should_use_env_file
branch
from
8968a11 to
0ace973
Compare
kev1n-peters
previously approved these changes
Dec 13, 2023
bruce-riley
previously approved these changes
Dec 13, 2023
panoel
dismissed stale reviews from bruce-riley and kev1n-peters
via
addb0c2
panoel
force-pushed
the
fly_should_use_env_file
branch
from
addb0c2 to
72522d1
Compare
bruce-riley
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes some hard coded tunables and expects them to be in a .env file.