Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloud_functions: add wormchainMonitor #143

Merged
merged 1 commit into from
Oct 30, 2023
Merged

cloud_functions: add wormchainMonitor #143

merged 1 commit into from
Oct 30, 2023

Conversation

panoel
Copy link
Contributor

@panoel panoel commented Oct 17, 2023

This PR adds the wormchain monitoring of IBC clients and will alert to slack or pager duty as needed.
The .json files were pulled from:
osmosis - https://github.com/cosmos/chain-registry/blob/master/osmosis/chain.json#L518
evmos - https://github.com/cosmos/chain-registry/blob/master/evmos/chain.json#L373
Kujira - https://github.com/cosmos/chain-registry/blob/master/kujira/chain.json#L235

barnjamin
barnjamin previously approved these changes Oct 18, 2023
Copy link
Contributor

@nik-suri nik-suri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! Few nits and comments on overall code structure.

Can we test the alerts and error cases by mocking Wormchain and foreign chain responses?

cloud_functions/src/wormchainMonitor.ts Outdated Show resolved Hide resolved
cloud_functions/src/wormchainMonitor.ts Outdated Show resolved Hide resolved
cloud_functions/src/wormchainMonitor.ts Outdated Show resolved Hide resolved
cloud_functions/src/wormchainMonitor.ts Outdated Show resolved Hide resolved
cloud_functions/src/wormchainMonitor.ts Outdated Show resolved Hide resolved
@panoel panoel force-pushed the wormchain_monitor branch from f955f27 to c01a746 Compare October 20, 2023 15:56
@panoel panoel requested review from nik-suri and barnjamin October 20, 2023 15:56
@panoel panoel force-pushed the wormchain_monitor branch 3 times, most recently from fb60de0 to d88a0ff Compare October 26, 2023 15:50
barnjamin
barnjamin previously approved these changes Oct 26, 2023
cloud_functions/src/wormchainMonitor.ts Outdated Show resolved Hide resolved
cloud_functions/src/wormchainMonitor.ts Outdated Show resolved Hide resolved
cloud_functions/src/wormchainMonitor.ts Show resolved Hide resolved
Copy link
Contributor

@nik-suri nik-suri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thanks!

@panoel panoel force-pushed the wormchain_monitor branch from 4326e40 to 65d0177 Compare October 30, 2023 13:51
@panoel panoel merged commit 5a42151 into main Oct 30, 2023
3 checks passed
@panoel panoel deleted the wormchain_monitor branch October 30, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants