feat(ci): add support for build-time flavors in Cargo.toml #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexKaravaev
approved these changes
Dec 19, 2024
ci/rust_ci_helper.py
Outdated
| tmp = package.get("metadata") or {} | ||
| tmp = tmp.get("orb") or {} | ||
| flavors = tmp.get("flavors") or {} | ||
| if flavors == {}: |
There was a problem hiding this comment.
nit: here and below probably more pythonic is if not flavors
ci/rust_ci_helper.py
Outdated
|
|
||
| def find_flavored_crates(*, workspace_crates): | ||
| def predicate(package): | ||
| tmp = package.get("metadata") or {} |
There was a problem hiding this comment.
also nit:
tmp = package.get("metadata", {}).get("orb", {})
flavors = tmp.get("flavors")
TheButlah
force-pushed
the
ryanbutler-orbs-233-implement-flavors-in-orb-softwares-ci
branch
from
312fbd9 to
1f6b41c
Compare
TheButlah
force-pushed
the
ryanbutler-orbs-233-implement-flavors-in-orb-softwares-ci
branch
from
1f6b41c to
b03698b
Compare
TheButlah
force-pushed
the
ryanbutler-orbs-233-implement-flavors-in-orb-softwares-ci
branch
from
b03698b to
8216402
Compare
TheButlah
deleted the
ryanbutler-orbs-233-implement-flavors-in-orb-softwares-ci
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.