[DNM] Remove Cargo workspace as Nix doesn't support it #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@andronat what should we do with this PR? |
|
@philsippl sorry this needs to stay open for now because @valff is still working on solving our Nix build system issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't merge this!
This is just a workaround for orb-core as our current nix build system doesn't support cargo workspaces on dependencies. This limitation will be lifted soon.
cc @valff
Refs: https://github.com/worldcoin/priv-orb-core/pull/1256 and https://github.com/worldcoin/priv-orb-core/pull/1255