Enable windows in Github actions

wildfly · Dec 8, 2023 · 36dfeac · 36dfeac
1 parent 5f0cacd
commit 36dfeac
Show file tree

Hide file tree

Showing 3 changed files with 58 additions and 4 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -1,5 +1,5 @@
 #
-# Copyright 2016-2021 Red Hat, Inc. and/or its affiliates
+# Copyright 2016-2023 Red Hat, Inc. and/or its affiliates
 # and other contributors as indicated by the @author tags.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
@@ -32,7 +32,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        os: [ubuntu-latest ]
+        os: [ubuntu-latest, windows-latest ]
         java: ['11']
 
     steps:

diff --git a/.../src/test/java/org/jboss/galleon/featurepack/xml/test/FeaturePackXml30ParserTestCase.java b/.../src/test/java/org/jboss/galleon/featurepack/xml/test/FeaturePackXml30ParserTestCase.java
@@ -1,5 +1,5 @@
 /*
- * Copyright 2016-2022 Red Hat, Inc. and/or its affiliates
+ * Copyright 2016-2023 Red Hat, Inc. and/or its affiliates
  * and other contributors as indicated by the @author tags.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
@@ -21,6 +21,7 @@
 
 import org.jboss.galleon.spec.FeaturePackSpec;
 import org.jboss.galleon.test.util.XmlParserValidator;
+import org.jboss.galleon.util.PropertyUtils;
 import org.jboss.galleon.xml.FeaturePackXmlParser;
 import org.junit.AfterClass;
 import org.junit.BeforeClass;
@@ -47,7 +48,11 @@ public static void resetLocale() {
 
     @Test
     public void readAbsoluteSystemPath() throws Exception {
-        validator.validateAndParse("xml/feature-pack/feature-pack-3.0-absolute-system-path.xml",
+        String path = "xml/feature-pack/feature-pack-3.0-absolute-system-path.xml";
+        if (PropertyUtils.isWindows()) {
+            path = "xml/feature-pack/feature-pack-3.0-absolute-system-path-win.xml";
+        }
+        validator.validateAndParse(path,
                                    null,
                                    "The content of 'system-path' element should be a path relative to installation base.");
     }

diff --git a/core/src/test/resources/xml/feature-pack/feature-pack-3.0-absolute-system-path-win.xml b/core/src/test/resources/xml/feature-pack/feature-pack-3.0-absolute-system-path-win.xml
@@ -0,0 +1,49 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+
+    Copyright 2016-2023 Red Hat, Inc. and/or its affiliates
+    and other contributors as indicated by the @author tags.
+
+    Licensed under the Apache License, Version 2.0 (the "License");
+    you may not use this file except in compliance with the License.
+    You may obtain a copy of the License at
+
+      http://www.apache.org/licenses/LICENSE-2.0
+
+    Unless required by applicable law or agreed to in writing, software
+    distributed under the License is distributed on an "AS IS" BASIS,
+    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+    See the License for the specific language governing permissions and
+    limitations under the License.
+
+-->
+<feature-pack xmlns="urn:jboss:galleon:feature-pack:3.0" location="org.jboss.fp.group1:fp1@galleon1:1#1.0.0" >
+
+  <dependencies>
+    <dependency location="org.jboss.dep.group1:dep1@galleon1:0#0.0.1"  />
+    <dependency location="org.jboss.dep.group2:dep2@galleon1:0#0.0.2">
+      <packages>
+        <exclude name="excluded-package1"/>
+        <exclude name="excluded-package2"/>
+        <include name="included-package1"/>
+        <include name="included-package2"/>
+      </packages>
+    </dependency>
+    <dependency location="org.jboss.dep.group2:dep3@galleon1:0#0.0.2">
+      <packages inherit="false">
+        <exclude name="excluded-package1"/>
+        <include name="included-package1"/>
+      </packages>
+    </dependency>
+  </dependencies>
+
+  <default-packages>
+    <package name="package1" />
+    <package name="package2" />
+  </default-packages>
+
+  <system-paths>
+    <system-path path="c:\\foo\\bar"/>
+  </system-paths>
+
+</feature-pack>