Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep error logs #202

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Keep error logs #202

wants to merge 3 commits into from

Conversation

johnyaku
Copy link

souporcell_pipeline.py captures STDERR streams to .err files but then deletes many of these, making troubleshooting difficult.

This PR simply deletes the lines that delete the .err files.

@johnyaku
Copy link
Author

Sorry. I thought I was doing this on my own fork for the project.
It is probably a good idea to keep these error logs for when things go wrong.
I'll test it in my own fork and get back to you

@wheaton5
Copy link
Owner

No problem. Thanks. Let me know. I guess i was deleting them bc things were getting pretty crowded. Maybe they should be hidden files or maybe all stored in a subdirectory?

@johnyaku
Copy link
Author

Never realised that I needed them until quite recently!
But I do like the idea of keeping all log files in a separate directory. If the pipeline runs successfully to completion, then we can just delete them. But the pipeline has a habit of powering on even when things go badly wrong, and atm it can be quite hard to figure out where things start going off the rails. That's where these logs might come in handy.
I've blown my quota on our HPC, so it might take a while to test this properly but I will let you know what I find!

@wheaton5
Copy link
Owner

Sounds good. This seems like the best path forward. Sorry to take up ur time.

@wheaton5
Copy link
Owner

Happy to merge once tested.

@wheaton5
Copy link
Owner

Thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants