Reconnect after all nodes were offline #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harunzengin
changed the title
harunzengin
changed the title
whatyouhide
reviewed
Dec 9, 2024
| @@ -327,8 +317,7 @@ defmodule Xandra.Cluster.Pool do | |||
| ) | |||
| when is_peername(peername) do | |||
| # Not connected anymore, but we're not really sure if the whole host is down. | |||
| data = put_in(data.peers[peername].status, :up) | |||
| data = stop_pool(data, data.peers[peername].host) | |||
There was a problem hiding this comment.
Wait, why were doing this and why are we not doing it anymore?
There was a problem hiding this comment.
Good catch, we should also maybe_start_pools after stop_pool.
Co-authored-by: Andrea Leopardi <an.leopardi@gmail.com>
|
@whatyouhide This should be ready |
whatyouhide
reviewed
Dec 11, 2024
|
@whatyouhide Done |
|
Fantastic work @harunzengin 💟 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the reconnectivity issue after all nodes were down.
Sends a
:host_upevent whenever a new control connection is established so thatXandra.Cluster.Poolcan start a pool and connect to that host.Also, fixes the issue where the load balancing state diverges from the peers state.
Closes #373.