Skip to content
This repository has been archived by the owner on Sep 15, 2021. It is now read-only.

Add badges, switch to concurrent full test runs, including Safari. #26

Merged
merged 2 commits into from
Dec 22, 2015

Conversation

ryan-roemer
Copy link
Contributor

/cc @exogen

@ryan-roemer ryan-roemer changed the title [WIP] Add badges, switch to concurrent full test runs, including Safari. Add badges, switch to concurrent full test runs, including Safari. Dec 22, 2015
{ "TEST_FUNC_PORT": 3070, "ROWDY_SETTINGS":"sauceLabs.safari_7_OS_X_10_9_Desktop" },
{ "TEST_FUNC_PORT": 3080, "ROWDY_SETTINGS":"sauceLabs.chrome_latest_Windows_2012_R2_Desktop" },
{ "TEST_FUNC_PORT": 3090, "ROWDY_SETTINGS":"sauceLabs.firefox_latest_Windows_2012_R2_Desktop" },
{ "TEST_FUNC_PORT": 3100, "ROWDY_SETTINGS":"local.firefox" } ]'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to wait for this feature so you don't get a confusing browser matrix result if one fails: FormidableLabs/builder#64

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@exogen -- This replaces the same existing matrix.

The badge is a "nice to have". But having any browser + OS combination failure is something that will not be left unattended -- there are no "acceptable" failures for this project.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, wouldn't have magellan needed the --bail_fast option before for it to be equivalent then? Either way, it seems to me that you'd still like to know if a change just broke one browser or every browser. But it doesn't matter too much.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Future work for "no bail" option captured with #27

@exogen
Copy link
Contributor

exogen commented Dec 22, 2015

Nice! I'm migrating the huge script loader build matrix to use builder envs as well. Testing all those script loaders takes hours.

btw, size badges for files on npmcdn are now supported, like so:

little-loader.min.js size

ryan-roemer added a commit that referenced this pull request Dec 22, 2015
Add badges, switch to concurrent full test runs, including Safari.
@ryan-roemer ryan-roemer merged commit e8a9fc5 into master Dec 22, 2015
@ryan-roemer ryan-roemer deleted the chore-ci-badges branch December 22, 2015 19:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants