-
Notifications
You must be signed in to change notification settings - Fork 28
Add badges, switch to concurrent full test runs, including Safari. #26
Conversation
38f5065
to
f2fdc97
Compare
f2fdc97
to
5dd8be6
Compare
{ "TEST_FUNC_PORT": 3070, "ROWDY_SETTINGS":"sauceLabs.safari_7_OS_X_10_9_Desktop" }, | ||
{ "TEST_FUNC_PORT": 3080, "ROWDY_SETTINGS":"sauceLabs.chrome_latest_Windows_2012_R2_Desktop" }, | ||
{ "TEST_FUNC_PORT": 3090, "ROWDY_SETTINGS":"sauceLabs.firefox_latest_Windows_2012_R2_Desktop" }, | ||
{ "TEST_FUNC_PORT": 3100, "ROWDY_SETTINGS":"local.firefox" } ]' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might want to wait for this feature so you don't get a confusing browser matrix result if one fails: FormidableLabs/builder#64
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@exogen -- This replaces the same existing matrix.
The badge is a "nice to have". But having any browser + OS combination failure is something that will not be left unattended -- there are no "acceptable" failures for this project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And in case it's not clear: This line is replacing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, wouldn't have magellan
needed the --bail_fast
option before for it to be equivalent then? Either way, it seems to me that you'd still like to know if a change just broke one browser or every browser. But it doesn't matter too much.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Future work for "no bail" option captured with #27
Add badges, switch to concurrent full test runs, including Safari.
builder
for various parallel helperssafari_7_OS_X_10_9_Desktop
on Sauce fails a lot. #5/cc @exogen