Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter Logs in ModList intaller view #2677

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

AlexDickerson
Copy link
Contributor

Currently all logs get displayed in the ModList installer. This causes some significant decreases in responsiveness. It also means that more meaningful messages like download failure are lost behind logs that aren't meaningful to most users.

This filters to warnings and above to reduce the noise and improve UI performance.

@tr4wzified
Copy link
Member

Personally not the biggest fan of this. I know for the average user this log might not say much, but in the new UI the log isn't visible by default anyway. Also, this log view is used on compilation where I think the author would definitely prefer a more verbose log about what's going on while things are happening. Is it that much faster if you log less info to the control? If there is a serious performance issue there I would rather fix that instead of just showing less info.

@AlexDickerson
Copy link
Contributor Author

The UI is significantly more responsive with fewer log statements being written out. There very likely is a way to improve performance but my knowledge of xaml/wpf stuff is not sufficient to know where to begin.

Maybe the filter could be exposed as a option somewhere in the UI?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants