chore: Add Jest testing lib; add utils/ tests #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrmykolyn
force-pushed
the
chore/add-tests
branch
from
e913039 to
8e4b7fa
Compare
|
CC: @jonasW3F for review. 🙏 |
|
Hi @jrmykolyn - Thanks! I will take a look as soon as I find the time |
Great, thanks a lot! Also, if there's anything I can do to make this (or future) pull requests easier to review, please let me know. 👍 |
joepetrowski
approved these changes
May 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
This pull request introduces the following changes:
Rationale:
Adding support for unit-level tests may increase the likelihood of additional contributions. It will also set a precedent in terms of what is expected for future contributions.
I have include a small number of tests for a small number of utility functions. If the pull request is accepted and merged then I'm happy to increase the test coverage. If not then only a small amount of time will be lost.
Why Jest?:
Jest is an widely-used and well-supported unit testing framework for JavaScript and TypeScript projects. The current number of monthly downloads via
npmis > 15,000,000. This is significantly more than other popular unit testing frameworks, such as Mocha (~6,000,000), Jasmine (~2,000,000), and Ava (~200,000).