Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add formatter #39

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

jrmykolyn
Copy link
Contributor

Overview:

This pull request introduces the following changes:

  • Adds support for formatting via the format script (ie. npm run format).
  • Automatically formats source code prior to commit.
  • Formats all src/ and config files.

It achieves this by introducing the following dependencies:

Additional Notes:

  • This pull request uses the 'out of the box' Prettier configuration. Additional information about Prettier's configuration options can be found here.
  • This pull request appears to be larger, but the it introduces a very small number of material changes. The changes made to the contents of src/ and config/ are programmatic formatting (ie. non-functional).

@jrmykolyn jrmykolyn force-pushed the chore/add-formatter branch from 8e839e0 to 15e6831 Compare March 11, 2022 23:44
@joepetrowski
Copy link
Collaborator

joepetrowski commented May 4, 2022

Thanks for this PR! I'm definitely in favor of adding a formatter. I just did a refactor which led a bunch of conflicts on this branch. Would you mind merging master?

As far as configurations go, I would follow the styles of other Polkadot integration tools like https://github.com/paritytech/txwrapper-core/ and https://github.com/paritytech/substrate-api-sidecar. That said, this prettier config greatly improves readability, would be happy to include this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants