Nicer error message for duplicate deps #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vuki656
reviewed
Aug 7, 2024
lua/package-info/tests/suites/config/register_user_options_spec.lua
Outdated
Show resolved
Hide resolved
vuki656
requested changes
Aug 7, 2024
vuki656
requested changes
Aug 8, 2024
lua/package-info/state.lua
Outdated
| @@ -21,6 +21,11 @@ M.dependencies = { | |||
| -- current: string - current dependency version | |||
| -- } | |||
| installed = {}, | |||
| -- dependencies that we were able to parse but something is wrong about them | |||
There was a problem hiding this comment.
You can remove this if it's not needed
|
Can you also add it to README? Otherwise looks good. I'll merge after |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to: #156
I apologize @vuki656, I was poking around for another I was going to propose when I noticed this highlight config. Some colors/icons seem like better feedback rather than
[ERROR].Here's a proposal pr to incorporate
.in_errordependencies to the state object. Let me know what you think and how I can polish it!