Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PropertyString, cleanHtml helper and escapeOrCleanHtml helper. #4004
base: dev
Are you sure you want to change the base?
Add PropertyString, cleanHtml helper and escapeOrCleanHtml helper. #4004
Changes from 9 commits
3b17e2a
be71629
d5c0ca5
c1ff4e9
da9165f
61ef47e
9bcfe47
1461a00
a1210ce
efa191a
bb45b75
5975e48
9f520cf
3d5df26
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is meant for linked data identifiers (i.e. URIs) for the string, but not sure. Is it practical to include some example use case with the demo driver, or should that wait for future PRs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which Demo driver did you have in mind? I don't think linked data IDs make a lot of sense in the context of something like book summaries, so I'm not sure how we would demonstrate them there. A better use case would be to add support in the appropriate MARC-based record driver traits, but that feels like a big enough change that it would be better as a follow-up than as part of this PR. I'm open to other ideas, though, if I'm misunderstanding your proposal!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No I agree, better to wait for another PR.