Fix behavior of php::packages::names_to_prefix #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation for php::packages::names_to_prefix suggests that the module will add php::package_prefix to the beginning of the listed package names. However, since the prefix() function is in the parameter default, the prefix is only applied to the default value (php::params::common_package_suffixes) rather than to user-defined php::packages::names_to_prefix. This commit fixes that behavior, so that either the default or user-defined php::packages::names_to_prefix will have prefixes added by the module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
The documentation for
php::packages::names_to_prefixsuggests that the module will addphp::package_prefixto the beginning of the listed package names. However, since theprefix()function is in the parameter default, the prefix is only applied to the default value (php::params::common_package_suffixes) rather than to user-definedphp::packages::names_to_prefix. This commit fixes that behavior, so that either the default or user-definedphp::packages::names_to_prefixwill have prefixes added by the module.This Pull Request (PR) fixes the following issues
n/a