Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a small Debian package for sml_server #137

Merged
merged 6 commits into from
Jan 6, 2024
Merged

Added a small Debian package for sml_server #137

merged 6 commits into from
Jan 6, 2024

Conversation

narc-Ontakac2
Copy link
Collaborator

This closes #131. I'll wait a week for reviews and complaints. Then I'll merge and do a release.

@r00t-
Copy link
Collaborator

r00t- commented Jan 4, 2024

i'm only a user of debian,
but i would expect the package to be named libsml-utils?
it could also be "Suggested" by the main package?

thanks for your work in any case!

@narc-Ontakac2
Copy link
Collaborator Author

Thanks for the suggestion. I did not like the name smlserver anyway but somehow missed the obvious.

@r00t-
Copy link
Collaborator

r00t- commented Jan 4, 2024

LGTM, feel free to merge as you see fit!
(i'd do a squash merge)

@narc-Ontakac2 narc-Ontakac2 merged commit f416b81 into volkszaehler:master Jan 6, 2024
2 checks passed
@narc-Ontakac2
Copy link
Collaborator Author

(i'd do a squash merge)

I had to enable squash merges in the project settings. Should I disable it again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sml_server not part of libsml1 debian package
2 participants