-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PreFitTube module. #138
base: master
Are you sure you want to change the base?
Conversation
Hello @lassoan, I am hereby proposing this module for inclusion in SlicerVMTK. Its main purpose is to simplify the drawing of a Shape::Tube markups node It uses GuidedVeinSegmentation to segment the lumen of an artery, diseased or As the name implies, 'Pre-fit', a post-processing step remains necessary to Overall, I found it to be of significant help on real cases. If you find it to be a worthy addition here, we may next discuss renaming the Thanks and regards. |
Thank you for working on this. I'm trying to understand what is the difference compared to |
A. The expected workflow if ExtractCenterline is modified would be:
B. The workflow in this proposal:
The implications with A:
The implications with B:
¹ is not something desirable, ² neither in my view. The pictures below show that both A and B can be done The notion of sane arteries handled in test data, and diseased arteries handled daily is of capital importance. The purpose of the tube is to represent the arterial wall, it is not visible in any imaging modality and can only be estimated by the observer. The tube is not meant to represent the lumen, it is easily segmented, and segmented (nearly) exactly. Thank you for your review. |
OK, if the dimension profile does not need a centerline with radius information (so that you can use it with a hand-drawn centerline) then it makes sense to have this as a separate module. The actual goal of the centerline seems to be manually drawing/editing centerline and radius; the end result could be in the same format as extract centerline results; and the module could be usable for editing automatically extracted or manually drawn centerline result. Therefore, I would recommend to consider naming the module |
Ok, there are more functionalities to add. However, I'm soon away for 2 weeks and somehow busy. I'll look into that in January. |
Sounds good! These features don't have to be added now, I just tried to find out what could be the long-term scope of the module because that helps with finding a module name that is self-explaining to users, and that remains accurate as the module is further developed. "Pre-fit" sounded like a first step of a task but it is better to implement a complete task in a module. |
20531cf
to
1c86d7d
Compare
1c86d7d
to
6072e63
Compare
Hello @lassoan, I renamed the module to EditCenterline. ExtraMarkups has been updated to show the spline of a Tube shape, this has meaning in this module. Later on, I plan to use an input centerline model/curve. The main question to resolve is the number of control point pairs to use in the output Tube node. Thank you for considering. |
6072e63
to
9efa25a
Compare
This module pre-fits a Shape::Tube markups node along an input markups curve that represents the axis of a non-aneurysmal artery.
9efa25a
to
a3257fa
Compare
The centerlines generated by ExtractCenterline can be used to create a Tube. The control points of the tube are positioned according to the radius array of the centerlines. The number of control point pairs is specified in the UI.
This is implemented in c4e3395. |
This module pre-fits a Shape::Tube markups node along an input markups curve that represents the axis of a non-aneurysmal artery.