feat: InitContainer support for ACI Connector #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-ysalazar
changed the title
mainaksarcar
suggested changes
Jun 10, 2022
|
@helayoty - Can you please help review this PR for InitContainers support? |
…lazar/azure-aci into t-ysalazar/init-containers
helayoty
reviewed
Nov 18, 2022
helayoty
reviewed
Nov 18, 2022
helayoty
reviewed
Nov 18, 2022
helayoty
reviewed
Nov 18, 2022
Fei-Guo
approved these changes
Nov 19, 2022
helayoty
approved these changes
Nov 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds ACI initContainers virtual node support to virtual kubelet. The user can add ACI initContainers to the pod definition.
ACI InitContainerDefinition
According to ACI documentation, InitContainerDefinition unlike Container does not support livenessProbe, ports, readinessProbe and resources.
Test
Validated the change by testing on minikube.
1.
2.
3.
Validated the change by testing on AKS.
References
https://docs.microsoft.com/en-us/rest/api/container-instances/container-groups/create-or-update#request-body
https://docs.microsoft.com/en-us/rest/api/container-instances/container-groups/create-or-update#initcontainerdefinition
https://docs.microsoft.com/en-us/rest/api/container-instances/container-groups/create-or-update#container
https://kubernetes.io/docs/concepts/workloads/pods/init-containers/