Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrictions needed for adding classes to the workspace #1

Closed
leon-k-martin opened this issue Aug 21, 2024 · 5 comments
Closed

Restrictions needed for adding classes to the workspace #1

leon-k-martin opened this issue Aug 21, 2024 · 5 comments
Assignees
Labels
bug Something isn't working invalid This doesn't seem right

Comments

@leon-k-martin
Copy link
Collaborator

Currently, there are no restrictions on the types of classes that can be added to the workspace. For example, I can assign PostsynapticPotential to Connectivity. The Connectivity field should only accept classes with it as a parent.
This issue can lead to improper class associations and potential errors in the workspace.

@leon-k-martin leon-k-martin added bug Something isn't working invalid This doesn't seem right labels Aug 21, 2024
@romina1601
Copy link
Collaborator

hi @leon-k-martin
we do have restrictions here: https://github.com/the-virtual-brain/tvb-ext-ontology/blob/d2f9d6ae5103bdd7ebfca363fd0c6de9c33985fd/src/App.tsx#L24
where we use the "type" attribute of a node to check if it can be added to the workspace. For connectivity, could you indicate what type should the nodes have to be allowed in the workspace? And can you give me some examples of connectivities from the ontology?

@leon-k-martin
Copy link
Collaborator Author

Great, thanks!

For the Connectivity, I think we'd need two Options:

  1. Select parcellation and normative tractogram from the Ontology: The Connectivity object is instantiated with average data with the desired network. The following tasks are needed

    • Update ontology with parcellations
    • Integration with tvbo-data to load matrices.
  2. Upload your own weights and length matrices.

What do you think?

@romina1601
Copy link
Collaborator

  1. Sounds good. Does the current ontology have any normative tractogram nodes? Also, I would have preferred for the user to select just one node for each case. I understand that for connectivities 2 nodes will be needed, right? We need to make sure that the users know this.
  2. I agree, this should be straightforward for the users to understand.

@leon-k-martin
Copy link
Collaborator Author

  1. For now, maybe let's make it simple and provide an option for selecting the parcellation for a normative SC without selecting the Tractogram (We only use one, so others can be added later). What do you say?

@romina1601
Copy link
Collaborator

  1. Sounds good 👍🏻 so for the moment I will disable adding any nodes to the Connectivity field from Workspace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

2 participants