Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(migrate.js, bin/rethinkdb-migrate): Implement step option on up and down commands #31

Merged
merged 3 commits into from
Aug 7, 2018

Conversation

gristow
Copy link
Collaborator

@gristow gristow commented Aug 1, 2018

See #20

  • Updated docs
  • Updated tests
  • Fixed getExecutedMigrations to only return executed migrations (not all migrations)
  • Replaced getAllMigrationsExecuted with getExecutedMigrations

@coveralls
Copy link

coveralls commented Aug 1, 2018

Coverage Status

Coverage decreased (-0.08%) to 97.279% when pulling 8414e4c on gristow:issue-20/step-option into bd3cb1b on vinicius0026:master.

@gristow
Copy link
Collaborator Author

gristow commented Aug 1, 2018

@vinicius0026 or @lirantal let me know if you want me to push commits to address codeclimate & coveralls failing tests. (I don't especially agree w/ codeclimate's suggested refactor but can get creative if need be...)

I think despite the 0.08% decrease in coverage the testing situation is better and more thorough now... but I can go back and catch that one LOC that became uncovered if you want. :-P

@vinicius0026
Copy link
Owner

Thank you for this PR, @gristow, very good work!

@lirantal do you want to go over it? I'll merge this, update dependencies and release v1.4 when you're good with this PR.

@lirantal
Copy link
Collaborator

lirantal commented Aug 3, 2018

I haven't thoroughly reviewed but this looks like a great addition!

@vinicius0026 vinicius0026 merged commit e2c58b0 into vinicius0026:master Aug 7, 2018
@gristow
Copy link
Collaborator Author

gristow commented Aug 8, 2018

Thanks for merging & publishing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants