Release candidate 1.8.0 #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Concurrent splash screens cause playback issues on one another. We can do better with synchronizing them. Probably not going to work miracles, the playback positions might be out of sync by up to 1 second. And weird stuff happens when opening/closing browsers mid-song. But at least they wont totally clobber the playback between the two like it currently does.
Will only show the end timestamp if fully buffered flag is specified, since we can't calculate it otherwise
|
Running on a single port and compatible with docker was just awesome. I did had to do a couple of trial and error to deploy this in a TRUENAS scale running iX apps. The only thing that I had to change to make this work with iX apps was to change the docker file environment to commands. Otherwise, I have successfully deploy it base on the screenshot images shown below. Currently using release candidate 1.8.0 but once this is pushed as the latest version, could change the tag to latest instead of rc-1.8.0. Maybe someone will be able to benefit from this if they are deploying the app via NAS. |
Some excellent work by @lvmasterrj A few todos before merging: [x] Resolve conflicts [x] Find a more ambient default bg music (I think this piano one will drive people crazy) [x] Convert ogg files to mp3 (ogg is not compatible with safari) [x] Clean up styling of the config page [x] Fix bug: score screen persists the previous message [x] Fix bug: skipping tracks can incorrectly trigger score [x] Fix bug: boolean prefs are not rendered properly on the info page ---- Hi @vicwomg, i've created some features that some users and my friends asked for. - Background music on splash screen - Score at the end of songs - Limit user songs in queue I've also created the possibility for the user to change preferences in the `info.html`, that are stored in a file called `config.ini`, so it doesn't have to change them in the command line everytime. I've added a `sounds` folder inside the `static` folder, to serve the sounds. == Background music == - A music that plays when the `splash` screen is in the screen. - I've setted the bg music to play on default but added a `--disable-bg-music` command line to disable it. - Also added a `--bg-music-volume` to set it's volume and a `--bg-music-path` so that the user can change the default bg music. == Score == - A fake score screen after each song is played. - It's in the `splash` screen. - I've created a `score.js` script and added a `fireworks.js` script to the `static` folder. - The score reaction (claps, fireworks and review) varies depending on the fake score value (under 30, under 60 or above 60). - The score reviews are stored in a variable inside the `splash` screen so that it can be translated. - I've setted the score to be shown by default but added a `--disable-score` command line to disable it. == Limit user songs by == - Limits songs a user can put simultaneously in queue. - The default limit is 0 (illimited) - The user can use the command line `--limit-user-songs-by` to set the desired limit. == User preferences == - In the info page, the user can set it's preferences. - Now it only holds this preferences (score on/off, bg music on/off, bg music volume and limit songs in queue) but we can add more reusing the same the api endpoint in `app` and the `change preferences`function in `karaoke`. There's more to do, and I hope to find some time to make it happen. If you have any doubts don't hold to ask me. Happy new year. :) --------- Co-authored-by: Leonardo Moreira <lvmasterrj@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todos:
Fix tmpdir handling, be less aggressive about deleting filesshoutcast streamsExplore need for the mov flagsfrag_keyframe+default_base_moofseem to break firefox