Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix( gcp_chronicle sink): add content encoding header when compression is enabled #22009

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ChocPanda
Copy link
Contributor

Summary

Set the Content Encoding header when configuring compression on the gcp chronicle sink

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

How did you test this PR?

Test using the config in the issue #22007

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the "no-changelog" label to this PR.

Checklist

  • Please read our Vector contributor resources.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run dd-rust-license-tool write to regenerate the license inventory and commit the changes (if any). More details here.

References

@ChocPanda ChocPanda requested a review from a team as a code owner December 10, 2024 16:43
@bits-bot
Copy link

bits-bot commented Dec 10, 2024

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the domain: sinks Anything related to the Vector's sinks label Dec 10, 2024
@pront
Copy link
Member

pront commented Dec 10, 2024

This looks good to me. I don't have an E2E environment to confirm how adding this header affects downstream GCP. Did you have a chance to see if you get 200 responses with this fix?

@pront pront changed the title fix(#22007): add content encoding header when compression is enabled fix(chronicle_unstructured sink): add content encoding header when compression is enabled Dec 13, 2024
Co-authored-by: Pavlos Rontidis <pavlos.rontidis@gmail.com>
@ChocPanda
Copy link
Contributor Author

This looks good to me. I don't have an E2E environment to confirm how adding this header affects downstream GCP. Did you have a chance to see if you get 200 responses with this fix?

I have got an environment I can test in I'm struggling to get a complete build to test. I'll keep trying

@pront pront changed the title fix(chronicle_unstructured sink): add content encoding header when compression is enabled fix( gcp_chronicle sink): add content encoding header when compression is enabled Jan 3, 2025
@pront
Copy link
Member

pront commented Jan 3, 2025

Test using the config in the issue #22007

Hi @ChocPanda, what I meant was, can you repeat what you described in the test plan?

Test using the config in the issue https://github.com/vectordotdev/vector/issues/22007

Also, a CI check is failing. Otherwise this is good to go!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: sinks Anything related to the Vector's sinks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants