Added short strut mechanism #931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ExportedVEFStrutGeometry can now have a fallback for when the geometry does not work. If any non-tip vertex computed is further from the origin than some tip vertex, the fallback geometry is tried, or null is returned if there is no fallback. I'm using FastDefaultStrutGeometry as a default fallback, so there should always be a strut rendered; this should retain invariants from before. In particular, switching styles will do the right thing as long as every strut is rendered; if a strut does not get rendered, it cannot be recovered by switching styles. This solves Paul's issue with "inside-out" r00 struts, but it goes much further, and avoids rendering *any* inside-out struts except for the very short default struts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExportedVEFStrutGeometry can now have a fallback for when the geometry
does not work. If any non-tip vertex computed is further from the origin than
some tip vertex, the fallback geometry is tried, or null is returned if there is no
fallback.
I'm using FastDefaultStrutGeometry as a default fallback, so there
should always be a strut rendered; this should retain invariants from before.
In particular, switching styles will do the right thing as long as every strut
is rendered; if a strut does not get rendered, it cannot be recovered by
switching styles.
This solves Paul's issue with "inside-out" r00 struts, but it goes much further,
and avoids rendering any inside-out struts except for the very short default
struts.