Merge pull request #956 from vorth/legacy-field-names

Fixes for 3 online bugs
vZome · Jan 11, 2025 · d093225 · d093225
2 parents 5c4c4cb + 5440ba0
commit d093225
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 5 deletions.
diff --git a/online/src/app/classic/menus/filemenu.jsx b/online/src/app/classic/menus/filemenu.jsx
@@ -131,7 +131,7 @@ export const FileMenu = () =>
   }
 
   // Open the design indicated in the query string, if any
-  onMount( () => url && openUrl( url ) );
+  onMount( () => ( url && url.endsWith( ".vZome" ) ) ? openUrl( url ) : doCreate( 'golden' ) );
 
   const [ svgPreview, setSvgPreview ] = createSignal( false );
 

diff --git a/online/src/app/framework/context/editor.jsx b/online/src/app/framework/context/editor.jsx
@@ -162,7 +162,6 @@ const EditorProvider = props =>
   {
     if ( ! state.controller ) {
       setState( 'controller', { __store: store, __path: [] } ); // empower every subcontroller to access this store
-      workerClient .postMessage( actions.newDesign() );
     }
     return state.controller;
   };

diff --git a/online/src/app/index.jsx b/online/src/app/index.jsx
@@ -64,8 +64,14 @@ const LegacyViewer = () =>
 
 const Online = () =>
 {
+  const reportError = err =>
+  {
+    console.log( 'ErrorBoundary:', err.toString() );
+    return <div>{err.toString()}</div>
+  }
+
   return (
-    <ErrorBoundary fallback={ err => <div>{err.toString()}</div> } >
+    <ErrorBoundary fallback={ reportError } >
       <CameraProvider name='main' >
         <WorkerProvider>
           <ImageCaptureProvider>

diff --git a/online/src/worker/legacy/controllers/index.js b/online/src/worker/legacy/controllers/index.js
@@ -110,6 +110,7 @@ const initializeDesign = ( loading, polygons, legacyDesign, clientEvents ) =>
     instances = snapshots .pop();
   } else {
     instances = renderHistory .getSnapshot( '--START--' );
+    snapshots = [];
   }
 
   const wrapper = createControllers( legacyDesign, renderingChanges, clientEvents );

diff --git a/online/src/worker/legacy/core.js b/online/src/worker/legacy/core.js
@@ -283,11 +283,12 @@ const makeFloatMatrices = ( matrices ) =>
 
   const fieldApps = {}
   const wrapLegacyField = ( legacyField ) => ({
-    origin: () => legacyField.origin( 3 ).getComponents().map( an => an.toTrailingDivisor() )
+    origin: () => legacyField.origin( 3 ).getComponents().map( an => an.toTrailingDivisor() ),
+    name: legacyField.getName(),
   })
   const addLegacyField = ( fieldClass, appClass ) =>
   {
-    const legacyField = new fieldClass( algebraicNumberFactory )
+    const legacyField = new fieldClass( algebraicNumberFactory );
     legacyField.delegate = wrapLegacyField( legacyField )
     fieldApps[ legacyField.getName() ] = new appClass( legacyField )
   }