Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ambiguous call to sycl::min #1990

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Fix ambiguous call to sycl::min #1990

merged 1 commit into from
Jan 7, 2025

Conversation

dmitriy-sobolev
Copy link
Contributor

__local_mem_size may differ from _Size in some cases leading to "error: call to 'min' is ambiguous".

adamfidel
adamfidel approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@adamfidel adamfidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Another alternative would be to change the auto __local_mem_size = /*...*/ to _Size __local_mem_size = /*...*/, but what you have is good as well!

@dmitriy-sobolev dmitriy-sobolev merged commit 204b9f9 into main Jan 7, 2025
23 checks passed
@dmitriy-sobolev dmitriy-sobolev deleted the dev/dmitriy-sobolev/min-fix branch January 7, 2025 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamfidel adamfidel adamfidel approved these changes

@SergeyKopienko SergeyKopienko Awaiting requested review from SergeyKopienko

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmitriy-sobolev @adamfidel