Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DEFAULT_ACCESSOR_CONSTRUCTOR_PRESENT macro #1986

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

dmitriy-sobolev
Copy link
Contributor

The feature is mistakenly enabled with older compilers, e.g. with icpx 2022.2.1, leading to:

error: constructor for 'oneapi::dpl::__par_backend_hetero::__usm_or_buffer_accessor<sycl::accessor<unsigned long, 1, sycl::access::mode::write, sycl::access::target::global_buffer, sycl::access::placeholder::false_t>>' must explicitly initialize the member '__acc' which does not have a default constructor

Copy link
Contributor

@danhoeflinger danhoeflinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming the original assessment from #1410 is accurate. (Supported by hotfixes of 2023.1 and 2023.2 but not by 2023.2.0)
This fixes the mistake in the recent changes. which flipped the && to ||.

Copy link
Contributor

@mmichel11 mmichel11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well

@dmitriy-sobolev dmitriy-sobolev merged commit 575ce0e into main Jan 2, 2025
23 checks passed
@dmitriy-sobolev dmitriy-sobolev deleted the dev/dmitriy-sobolev/acc-ctor-fix branch January 2, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants