Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RNG][device_tests][interface_tests][statistics_tests] Shortening some test file names to avoid warnings on Windows #1963

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

egrabovskaya
Copy link
Contributor

@egrabovskaya egrabovskaya commented Dec 9, 2024

The next warning was noticed on Windows when running manually:

1> [CMake] CMake Warning in test/CMakeLists.txt:
1> [CMake]   The object file directory
1> [CMake] 
1> [CMake]     C:/Work/github-oneapi/out/build/x64-Debug C++17 dpcpp icpx -fsycl Un.L.Off/test/CMakeFiles/extreme_value_distribution_dp_tests_set_portion_test.pass.dir/./
1> [CMake] 
1> [CMake]   has 155 characters.  The maximum full path to an object file is 250
1> [CMake]   characters (see CMAKE_OBJECT_PATH_MAX).  Object file

We shortened test file names which are too long to avoid future issues

@egrabovskaya egrabovskaya requested a review from aelizaro December 9, 2024 16:59
@aelizaro
Copy link
Contributor

Please, add a description to the PR

Copy link
Contributor

@aelizaro aelizaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look ok to me, thank you! Just description + probably [Tests] in PR's name are needed
Details about warnings on Win OS can be put into description and/or the second line of the commit message

@egrabovskaya egrabovskaya changed the title [RNG] Shortening some test file names to avoid warnings on Windows [RNG][device_tests][interface_tests][statistics_tests] Shortening some test file names to avoid warnings on Windows Dec 11, 2024
@egrabovskaya
Copy link
Contributor Author

The changes look ok to me, thank you! Just description + probably [Tests] in PR's name are needed Details about warnings on Win OS can be put into description and/or the second line of the commit message

Thank you, Alina!

@egrabovskaya egrabovskaya merged commit 59d30e0 into main Dec 11, 2024
22 checks passed
@egrabovskaya egrabovskaya deleted the dev/egrabovs/shortening_test_file_names branch December 11, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants