Remove usage of __kernel_name_generator as not required for non-compiled Kernel's
#1935
+112
−96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergeyKopienko
requested review from
rarutyun
and removed request for
rarutyun
… usage of __kernel_name_generator as not required Signed-off-by: Sergey Kopienko <sergey.kopienko@intel.com>
SergeyKopienko
force-pushed
the
dev/skopienko/fix_kernel_name_generator_usage
branch
from
acc4f20 to
c1da480
Compare
SergeyKopienko
changed the title
__kernel_name_generator as not required__kernel_name_generator as not required for non-compiled Kernel's
Signed-off-by: Sergey Kopienko <sergey.kopienko@intel.com>
danhoeflinger
previously approved these changes
Jan 2, 2025
There was a problem hiding this comment.
This seems like a reasonable change. I agree that the __kernel_name_generator should not be necessary here because we have no need to pre-compile the kernel and interrogate characteristics of the compiled kernel, and therefore shouldn't be used.
I'm OK with removing the device_backend_tag argument as well, but I want to draw attention to it and make sure we consider that, as it isn't in the original goal of the PR.
It would be good to get another approval here, but I think it looks good.
…view comment: restore __device_backend_tag in __parallel_find_or_impl_one_wg::operator() and __parallel_find_or_impl_multiple_wgs::operator()
|
Filed spelling check will fixed in separate PR #1998 |
…ernelName template parameter to last position
rarutyun
reviewed
Jan 15, 2025
…view comment: rename _KernelName to __find_or_kernel_name
…view comment: rename _KernelName to __find_or_one_wg_kernel_name / __find_or_kernel_name
rarutyun
approved these changes
Jan 15, 2025
SergeyKopienko
deleted the
dev/skopienko/fix_kernel_name_generator_usage
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we remove usage of
__kernel_name_generatorfrom__parallel_find_oras not required.We should avoid to use
__kernel_name_generatorfor not-compiler Kernels (when absent the call of__kernel_compilerin the code) due a lot of char codes in template names.For example we may see these names with char codes from VTune.
Attention :
Otherwise you will see a lot of unsignificant changes due the formatting has been changed.
Thanks.