Make kernel names unique in radix sort #1927
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1922. You can find elaborate description of the issue there.
It appears that
_Proj
, a lambda declared in__pattern_sort_by_key
template, will have different types for different__patter_sort_by_key
instantiations:https://github.com/oneapi-src/oneDPL/blob/28cb633583570457a2e21a752f6a517f5fc7134a/include/oneapi/dpl/pstl/hetero/algorithm_impl_hetero.h#L1274-L1275
Here is a simplified example of a lambda having different types in different function template instantiations: https://godbolt.org/z/ddrM6Tseq