Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test_policies for FPGA #1918

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Fix test_policies for FPGA #1918

merged 1 commit into from
Oct 23, 2024

Conversation

dmitriy-sobolev
Copy link
Contributor

@dmitriy-sobolev dmitriy-sobolev commented Oct 23, 2024 •
edited
Loading

A straightforward fix would be to add missing >. However, testing the fpga_policy as it is looks a better choice due to being a basic case. I guess the change in #1907 with wrapping fpga_policy into device_policy was a typo.

@dmitriy-sobolev
Fix test_policies for FPGA
c1f72c3 
Signed-off-by: Dmitriy Sobolev <dmitriy.sobolev@intel.com>
@dmitriy-sobolev dmitriy-sobolev added the test Test only Change label Oct 23, 2024
adamfidel
adamfidel approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@adamfidel adamfidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. The addition of the device_policy was indeed a typo. Thanks!

@dmitriy-sobolev dmitriy-sobolev merged commit 66ead74 into main Oct 23, 2024
23 checks passed
@dmitriy-sobolev dmitriy-sobolev deleted the dev/dmitriy-sobolev/test_policies branch October 23, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamfidel adamfidel adamfidel approved these changes

Assignees
No one assigned
Labels
test Test only Change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmitriy-sobolev @adamfidel