Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chmod: add support for the deref and links options #7025

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

chmod: add support for the deref and links options #7025

wants to merge 5 commits into from

Conversation

sylvestre
Copy link
Contributor

@sylvestre sylvestre commented Dec 29, 2024 •
edited
Loading

Closes: #7023

@sylvestre sylvestre force-pushed the chmod-L-2 branch 2 times, most recently from 9c02aba to 05d59bf Compare December 30, 2024 10:29
@sylvestre
Copy link
Contributor Author

@jfinkels what I was mentioning yesterday

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/chmod/symlinks is no longer failing!

@sylvestre sylvestre force-pushed the chmod-L-2 branch 6 times, most recently from d06f8ea to d93b699 Compare December 30, 2024 12:12
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/chmod/symlinks is no longer failing!
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

@sylvestre sylvestre marked this pull request as ready for review December 30, 2024 12:55
@sylvestre
Copy link
Contributor Author

it is the last failing test for chmod:
image

I also noticed this problem upstream:
https://lists.gnu.org/archive/html/coreutils/2024-12/msg00042.html

@sylvestre
Copy link
Contributor Author

I will simplify the tests later. I think they could be merged

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/chmod/symlinks is no longer failing!

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/chmod/symlinks is no longer failing!
Congrats! The gnu test tests/seq/seq is no longer failing!

@sylvestre sylvestre requested a review from cakebaker January 2, 2025 10:26
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 5, 2025

GNU testsuite comparison:

Congrats! The gnu test tests/chmod/symlinks is no longer failing!
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfinkels jfinkels Awaiting requested review from jfinkels

@tertsdiepraam tertsdiepraam Awaiting requested review from tertsdiepraam

@cakebaker cakebaker Awaiting requested review from cakebaker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chmod: -L option fails to traverse symlinks
2 participants
@sylvestre @cakebaker