Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/selections component #39

Merged
merged 3 commits into from
Dec 5, 2023
Merged

Feature/selections component #39

merged 3 commits into from
Dec 5, 2023

Conversation

jinukeu
Copy link
Member

@jinukeu jinukeu commented Dec 4, 2023

๐Ÿ“Œ PR ์š”์•ฝ

๐ŸŒฑ ์ž‘์—…ํ•œ ๋‚ด์šฉ

  • Slider
  • Dropdown

๐ŸŒฑ PR ํฌ์ธํŠธ
๋””์ž์ด๋„ˆ๋‹˜์ด theme ๊ด€๋ จ ์ž‘์—…์„ ๋งˆ์นœ ์ดํ›„์— ํฐํŠธ, ์ƒ‰์ƒ ๋“ฑ์„ ์ ์šฉํ•  ์˜ˆ์ •์ž…๋‹ˆ๋‹ค. ์šฐ์„ ์€ ๊ธฐ๋Šฅ ์œ„์ฃผ๋กœ ์ฝ”๋“œ ๋ฆฌ๋ทฐ ๋ถ€ํƒ๋“œ๋ฆฝ๋‹ˆ๋‹ค.

๐Ÿ“ธ ์Šคํฌ๋ฆฐ์ƒท

Slider Dropdown
slider dropdown

๐Ÿ“ฎ ๊ด€๋ จ ์ด์Šˆ

@jinukeu jinukeu requested review from lsakee and BEEEAM-J December 4, 2023 05:32
@jinukeu jinukeu self-assigned this Dec 4, 2023
BEEEAM-J
BEEEAM-J approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@BEEEAM-J BEEEAM-J left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊น”๋”ํ•˜๋„ค์œ  ๐Ÿ‘๐Ÿ‘

@jinukeu jinukeu added the feature label Dec 4, 2023
@lsakee
Copy link
Contributor

lsakee commented Dec 5, 2023

LGTM ๊ณ ์ƒํ•˜์…จ์Šต๋‹ˆ๋‹ค!!

@jinukeu jinukeu merged commit a0edbd6 into develop Dec 5, 2023
1 check passed
@jinukeu jinukeu deleted the feature/selections-component branch December 5, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BEEEAM-J BEEEAM-J BEEEAM-J approved these changes

@lsakee lsakee Awaiting requested review from lsakee

Assignees

@jinukeu jinukeu

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feat] Selections Component
3 participants
@jinukeu @lsakee @BEEEAM-J