blog de html hecho en componentes de react agregue t odas las funciones de js que teniamos hechas en la carpeta utils #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es de js que teniamos hechas en la carpeta utils
Pancratzia
reviewed
May 5, 2023
react-blogs/MonsterT-9886/index.html
Outdated
Comment on lines
21
to
134
| <article></article> | ||
|
|
||
| </section> | ||
| <section class="post-list-container"> | ||
| <nav class="tags-filter"> | ||
| <div class="filter-list-scroll-hider"> | ||
| <ul class="nav-list filter-list"> | ||
| <li class="is-active-filter"><a class="filter paragraph paragraph-sm font-bold" | ||
| href="#">Todos</a></li> | ||
| <li><a class="filter paragraph paragraph-sm font-bold" href="#">Airdrops</a></li> | ||
| <li><a class="filter paragraph paragraph-sm font-bold" href="#">Gems</a></li> | ||
| <li><a class="filter paragraph paragraph-sm font-bold" href="#">Web3writing</a></li> | ||
| <li><a class="filter paragraph paragraph-sm font-bold" href="#">Web development</a></li> | ||
|
|
||
| </ul> | ||
|
|
||
| </div> | ||
| <input class="input" type="search" placeholder="Buscar"> | ||
| <div class="button-container"> | ||
| <button>Atras</button> | ||
| <button>Adelante</button> | ||
| </div> | ||
|
|
||
| </nav> | ||
| <div class="post-list"> | ||
| <article class="card"> | ||
| <img src="https://images.unsplash.com/photo-1634704784915-aacf363b021f?ixlib=rb-4.0.3&ixid=MnwxMjA3fDB8MHxwaG90by1wYWdlfHx8fGVufDB8fHx8&auto=format&fit=crop&w=870&q=80" alt="Imagen de un post"> | ||
| <section> | ||
| <div class="card-content"> | ||
| <header> | ||
| <div class="tags"> | ||
| <span class="tag tag-primary"><a href="#">Airdropss</a></span> | ||
| <span class="tag tag-primary"><a href="#">Web3writing</a></span> | ||
| </div> | ||
| <h2 class="heading heading-sm font-bold"></h2> | ||
| <time class="help-text paragraph paragraph-xs font-regular" datetime="2022-01-24"> | ||
| 2022-01-24 | ||
| </time> | ||
| </header> | ||
| <p class="paragraph paragraph-sm font-regular">Airdrops? blockchains mas importantes para y como farmear...</p> | ||
| </div> | ||
| <footer> | ||
| <div class="author"> | ||
| <img src="https://i.pravatar.cc/300" alt="Avatar de un autor"> | ||
| <span class="paragraph paragraph-xs font-bold">TSAD</span> | ||
| </div> | ||
| <span class="help-text paragraph paragraph-xs font-regular"> | ||
| 7 min lectura | ||
| </span> | ||
| </footer> | ||
| </section> | ||
| </article> | ||
| <article class="card"> | ||
| <img src="https://images.unsplash.com/photo-1503642551022-c011aafb3c88?ixlib=rb-4.0.3&ixid=MnwxMjA3fDB8MHxwaG90by1wYWdlfHx8fGVufDB8fHx8&auto=format&fit=crop&w=870&q=80" alt="Imagen de un post"> | ||
| <section> | ||
| <div class="card-content"> | ||
| <header> | ||
| <div class="tags"> | ||
| <span class="tag tag-primary"><a href="#">Web3writing</a></span> | ||
| <span class="tag tag-primary"><a href="#">Copywriting</a></span> | ||
| </div> | ||
| <h2 class="heading heading-sm font-bold"> | ||
| <time class="help-text paragraph paragraph-xs font-regular" datetime="2023-01-24"> | ||
| 2023-01-24 | ||
| </time> | ||
| </header> | ||
| <p class="paragraph paragraph-sm font-regular">Como comenzar una carrera como escritor sobre temas de web3 ?...</p> | ||
| </div> | ||
| <footer> | ||
| <div class="author"> | ||
| <img src="https://i.pravatar.cc/300" alt="Avatar de un autor"> | ||
| <span class="paragraph paragraph-xs font-bold">TSAD</span> | ||
| </div> | ||
| <span class="help-text paragraph paragraph-xs font-regular"> | ||
| 7 min lectura | ||
| </section> | ||
| </article> | ||
| <article class="card"> | ||
| <img src="https://images.unsplash.com/photo-1500134697073-dc9b3b4409c5?ixlib=rb-4.0.3&ixid=MnwxMjA3fDB8MHxwaG90by1wYWdlfHx8fGVufDB8fHx8&auto=format&fit=crop&w=870&q=80" alt="Imagen de un post"> | ||
| <section> | ||
| <div class="card-content"> | ||
| <header> | ||
| <div class="tags"> | ||
| <span class="tag tag-primary"><a href="#">Latinoamerica</a></span> | ||
| <span class="tag tag-primary"><a href="#">Crypto</a></span> | ||
| </div> | ||
| <h2 class="heading heading-sm font-bold"> | ||
| <time class="help-text paragraph paragraph-xs font-regular" datetime="2023-01-24"> | ||
| 2023-01-24 | ||
| </time> | ||
| </header> | ||
| <p class="paragraph paragraph-sm font-regular">Que impacto tienen hoy en dia el acceso a los cryptoactivos respecto a la movilidad social en Latam ?...</p> | ||
| </div> | ||
| <footer> | ||
| <div class="author"> | ||
| <img src="https://i.pravatar.cc/300" alt="Avatar de un autor"> | ||
| <span class="paragraph paragraph-xs font-bold">TSAD</span> | ||
| </div> | ||
| <span class="help-text paragraph paragraph-xs font-regular"> | ||
| 7 min lectura |
There was a problem hiding this comment.
Hola! Veo que has colocado todo el código HTML aquí en el index. Sin embargo, aquí solo debería estar el root para que el main.jsx coloque o pinte los componentes que creaste
There was a problem hiding this comment.
Hola realmente los componentes están es en app.jsx que es donde están los componentes y al final del html tenemos el div del root
There was a problem hiding this comment.
Exacto. Sin embargo, no deberías tener nada más en el index, solo el root. Intenté dejar solamente el div con el root, pero la página quedó en blanco, lo que indica que tus componentes no se están colocando correctamente.
Pancratzia
approved these changes
May 8, 2023
MauBedoya
suggested changes
May 9, 2023
There was a problem hiding this comment.
Parece estar correcto el funcionamiento de vite con react, pero hay varios estilos que no están coincidiendo con las clases que parece que deberían, por ejemplo en App.css tienes: .MainNavbar pero en el componente MainNavbar la className esta como main-navbar, y así varios mas en distintos archivos, quizá por eso no se esta cargando del todo bien tu layout:
No estoy seguro de si ocurrió algo al momento de migrar o si esta pensado así y estoy revisando algo mal, seria solo que me confirmes eso y ya estaría el approve.
| return ( | ||
| <Fragment> | ||
| <section className="post-list-container"> | ||
| <div className="post-card-container"> |
There was a problem hiding this comment.
este div parece no estar recibiendo ningún estilo, parece que se podría eliminar sin que afecte
Andrssnsdc
approved these changes
May 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…es de js que teniamos hechas en la carpeta utils