ejercicio semana 6: de html a react #31
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EzequielCaste
suggested changes
Jun 2, 2023
There was a problem hiding this comment.
Vamos por partes:
- el color del fondo verde no hace buen contraste con el color azul del link a "Blog"
- las fechas no están humanizadas, sigo viendo "2023-04-18"
con respecto al código:
- hay un Warning sobre la KEY que require React cuando iteramos o hacemos map sobre un array (Warning: Each child in a list should have a unique "key" prop.)
- también hay una etiqueta
<body>duplicada. sólo se permite un body por documento html.
AliannaFormoso
approved these changes
Jun 5, 2023
There was a problem hiding this comment.
Hola!
Si, intenta solucionar lo que te ha dicho el revisor anterior. Yo no sabia como hacer lo de la key y gracias a uno de mis revisores en sus comentarios pude. Body si, siempre solo uno, es que con tanto codigo se nos van cosas, por suerte estan las revisiones que nos ayudan mucho a mejorar. Lo referente al diseño siempre es bueno tener en cuenta los contrastes si. Por lo demas todo muy bien.
|
ejercicio OK✌️✌️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.