Do not allow editing read-only properties #17915
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
If there's an existing issue for this PR then this fixes #16615 (and #17889 and #17906)
Description
As described in the linked issues, read-only properties (e.g. labels) are reset upon save.
It should not be possible to edit read-only properties, so that's what this PR ensures 😄
Testing this PR
Create some content with a label property, and add a value to that label property .... for example, use this controller to update exiting content:
Edit the content and save it. Verify that the label property value is retained after the save 👍