correct null case

umbraco · Jan 9, 2025 · bd456a1 · bd456a1
1 parent f862736
commit bd456a1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/Umbraco.Web.UI.Client/src/libs/class-api/class.mixin.ts b/src/Umbraco.Web.UI.Client/src/libs/class-api/class.mixin.ts
@@ -59,7 +59,8 @@ export const UmbClassMixin = <T extends ClassConstructor<EventTarget>>(superClas
 			// Fallback to use a hash of the provided method, but only if the alias is undefined and there is a callback.
 			if (controllerAlias === undefined && callback) {
 				controllerAlias = simpleHashCode(callback.toString());
-			} else {
+			} else if (controllerAlias === null) {
+				// if value is null, then reset it to undefined. Null is used to explicitly tell that we do not want a controller alias. [NL]
 				controllerAlias = undefined;
 			}
 

diff --git a/src/Umbraco.Web.UI.Client/src/libs/element-api/element.mixin.ts b/src/Umbraco.Web.UI.Client/src/libs/element-api/element.mixin.ts
@@ -35,7 +35,8 @@ export const UmbElementMixin = <T extends HTMLElementConstructor>(superClass: T)
 			// Fallback to use a hash of the provided method, but only if the alias is undefined and there is a callback.
 			if (controllerAlias === undefined && callback) {
 				controllerAlias = simpleHashCode(callback.toString());
-			} else {
+			} else if (controllerAlias === null) {
+				// if value is null, then reset it to undefined. Null is used to explicitly tell that we do not want a controller alias. [NL]
 				controllerAlias = undefined;
 			}